In all but a few instances you should leave Find My iPhone on to protect your device.
https://www.howtogeek.com/how-to-turn-off-find-my-iphone/?utm_source=dlvr.it&utm_medium=blogger
https://www.howtogeek.com/how-to-turn-off-find-my-iphone/?utm_source=dlvr.it&utm_medium=blogger